Navy.gif/owncast
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

framerates #1138 (#326)

Browse Source 
* framerates #1138


https://github.com/owncast/owncast/issues/1138#
This is a technically correct and low to no risk making the low end default 25.

now has 25 default, 30, 50, 60 and outrageous. This is a good balance as the standard in NA and Japan and such and such is still 30/60 and EU etc is 25/50. So I've just piggybacked the same description for 50 and 60 options and tacked an EU and NA on them.

Pardon my ignorance but I cannot find where the heck the default visual stream options name only is being generated. I've tried reinstalling owncast on top my edited admin no dice.

tested with all variants individual and stacked with no issues.

* Update config-constants.tsx

per discussion reintroduced the 24fps default thus removing any paradox with the core code text visual naming
removed NA , EU references

re-tested
This commit is contained in:
controlfreak 2021-10-14 14:46:21 +13:00 committed by GitHub
parent 4661cb67aa
commit e7e757a53e
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/utils/config-constants.tsx
View File

@ -233,14 +233,18 @@ export const FRAMERATE_DEFAULTS = {
};
export const FRAMERATE_SLIDER_MARKS = {
[FRAMERATE_DEFAULTS.min]: `${FRAMERATE_DEFAULTS.min} ${FRAMERATE_DEFAULTS.unit}`,
25: '',
30: '',
50: '',
60: '',
90: '',
[FRAMERATE_DEFAULTS.max]: `${FRAMERATE_DEFAULTS.max} ${FRAMERATE_DEFAULTS.unit}`,
};
export const FRAMERATE_TOOLTIPS = {
[FRAMERATE_DEFAULTS.min]: `${FRAMERATE_DEFAULTS.min}fps - Good for film, presentations, music, low power/bandwidth servers.`,
25: '25fps - Good for film, presentations, music, low power/bandwidth servers.',
30: '30fps - Good for slow/casual games, chat, general purpose.',
50: '50fps - Good for fast/action games, sports, HD video.',
60: '60fps - Good for fast/action games, sports, HD video.',
90: '90fps - Good for newer fast games and hardware.',
[FRAMERATE_DEFAULTS.max]: `${FRAMERATE_DEFAULTS.max}fps - Experimental, use at your own risk!`,