From 4ed0d8cae4378116215ec588654b790f71b127d7 Mon Sep 17 00:00:00 2001 From: Gabe Kangas Date: Sun, 23 Jul 2023 10:15:04 -0700 Subject: [PATCH] Update standard-pull-request.md --- .github/PULL_REQUEST_TEMPLATE/standard-pull-request.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/standard-pull-request.md b/.github/PULL_REQUEST_TEMPLATE/standard-pull-request.md index 2661cfac6..cbcb61ed0 100644 --- a/.github/PULL_REQUEST_TEMPLATE/standard-pull-request.md +++ b/.github/PULL_REQUEST_TEMPLATE/standard-pull-request.md @@ -1,6 +1,8 @@ Please include a summary of the change and which issue number is fixed, including relevant motivation and context. Feel free to mark this as a Draft or WIP and write up some details later. +If there is no issue filed for this particular change it's highly recommended you file one. While creating this PR means you probably already did the work, in the future make sure an issue is filed beforehand so changes, fixes and features can be discussed ahead of time. + # Description Fixes # (issue) @@ -14,4 +16,4 @@ Some things you might want to mention: 3. If you're fixing something, what was wrong? How should we stop from having this issue happen again? 4. If this is a new feature or addition to functionality, why should it be added? What are the use cases? Who was asking for this functionality? -If this is an unsolicited change or have no issue associated please do your best to detail the motivations behind this PR. +If this is an unsolicited change or have no issue associated please do your best to detail the motivations behind this PR, and think about filing an issue to discuss changes ahead of time in the future.