From 16e578e99301f0f0b62dd6632de8a8d1528bb66e Mon Sep 17 00:00:00 2001 From: Christian Muehlhaeuser Date: Thu, 12 Nov 2020 23:42:39 +0100 Subject: [PATCH] Use a golangci-lint workflow to check for common mistakes & problems (#353) --- .github/workflows/lint.yml | 22 ++++++++++++++++++++++ .golangci.yml | 25 +++++++++++++++++++++++++ 2 files changed, 47 insertions(+) create mode 100644 .github/workflows/lint.yml create mode 100644 .golangci.yml diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml new file mode 100644 index 000000000..e85fdcdc9 --- /dev/null +++ b/.github/workflows/lint.yml @@ -0,0 +1,22 @@ +name: lint +on: + push: + pull_request: + +jobs: + golangci: + name: lint + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - name: golangci-lint + uses: golangci/golangci-lint-action@v2 + with: + # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version. + version: v1.31 + # Optional: golangci-lint command line arguments. + args: --issues-exit-code=0 + # Optional: working directory, useful for monorepos + # working-directory: somedir + # Optional: show only new issues if it's a pull request. The default value is `false`. + only-new-issues: true diff --git a/.golangci.yml b/.golangci.yml new file mode 100644 index 000000000..0a17badeb --- /dev/null +++ b/.golangci.yml @@ -0,0 +1,25 @@ +run: + tests: false + +issues: + max-issues-per-linter: 0 + max-same-issues: 0 + +linters: + enable: + - bodyclose + - dupl + - exportloopref + - goconst + - godot + - godox + - goimports + - goprintffuncname + - gosec + - misspell + - prealloc + - rowserrcheck + - sqlclosecheck + - unconvert + - unparam + - whitespace