Navy.gif/glfw
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove ignored Clang compiler flag

Browse Source 
Clang ignores this when C99 is enabled, while GCC does not.  Removing
the checks for Clang to hopefully avoid a false sense of security.
This commit is contained in:
Camilla Löwy 2020-10-07 21:40:16 +02:00
parent 35f3508ecd
commit 9b140d08d7
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/CMakeLists.txt
View File

@ -121,18 +121,20 @@ if (APPLE)
LANGUAGE C) LANGUAGE C)
endif() endif()
if ("${CMAKE_C_COMPILER_ID}" STREQUAL "GNU" OR # Make GCC warn about declarations that VS 2010 and 2012 won't accept for all
"${CMAKE_C_COMPILER_ID}" STREQUAL "Clang" OR # source files that VS will build (Clang ignores this because we set -std=c99)
"${CMAKE_C_COMPILER_ID}" STREQUAL "AppleClang") if ("${CMAKE_C_COMPILER_ID}" STREQUAL "GNU")
# Make GCC and Clang warn about declarations that VS 2010 and 2012 won't
# accept for all source files that VS will build
set_source_files_properties(context.c init.c input.c monitor.c vulkan.c set_source_files_properties(context.c init.c input.c monitor.c vulkan.c
window.c win32_init.c win32_joystick.c window.c win32_init.c win32_joystick.c
win32_monitor.c win32_time.c win32_thread.c win32_monitor.c win32_time.c win32_thread.c
win32_window.c wgl_context.c egl_context.c win32_window.c wgl_context.c egl_context.c
osmesa_context.c PROPERTIES osmesa_context.c PROPERTIES
COMPILE_FLAGS -Wdeclaration-after-statement) COMPILE_FLAGS -Wdeclaration-after-statement)
endif()
if ("${CMAKE_C_COMPILER_ID}" STREQUAL "GNU" OR
"${CMAKE_C_COMPILER_ID}" STREQUAL "Clang" OR
"${CMAKE_C_COMPILER_ID}" STREQUAL "AppleClang")
# Enable a reasonable set of warnings (no, -Wextra is not reasonable) # Enable a reasonable set of warnings (no, -Wextra is not reasonable)
target_compile_options(glfw PRIVATE "-Wall") target_compile_options(glfw PRIVATE "-Wall")