Wayland: Fix some keys not repeating
According to the libxkbcommon documentation[1], xkb_keymap_key_repeats requires keymap and keycode as input: int xkb_keymap_key_repeats( struct xkb_keymap * keymap, xkb_keycode_t key) However, in inputChar in wl_input.c we are passing in xkb_keysym_t, which was a type mismatch. This results in some keys not repeating when they should and vice versa. [1] https://xkbcommon.org/doc/current/group__components.html#ga9d7f998efeca98b3afc7c257bbac90a8 Closes #1908.
This commit is contained in:
parent
63da04e5ce
commit
216d5e8402
@ -245,6 +245,7 @@ information on what to include when reporting a bug.
|
||||
- [Wayland] Bugfix: Client-Side Decorations were destroyed in the wrong worder
|
||||
(#1798)
|
||||
- [Wayland] Bugfix: Monitors physical size could report zero (#1784,#1792)
|
||||
- [Wayland] Bugfix: Some keys were not repeating in Wayland (#1908)
|
||||
- [POSIX] Removed use of deprecated function `gettimeofday`
|
||||
- [POSIX] Bugfix: `CLOCK_MONOTONIC` was not correctly tested for or enabled
|
||||
- [NSGL] Removed enforcement of forward-compatible flag for core contexts
|
||||
@ -357,6 +358,7 @@ skills.
|
||||
- Arseny Kapoulkine
|
||||
- Cem Karan
|
||||
- Osman Keskin
|
||||
- Koray Kilinc
|
||||
- Josh Kilmer
|
||||
- Byunghoon Kim
|
||||
- Cameron King
|
||||
|
@ -565,7 +565,7 @@ static GLFWbool inputChar(_GLFWwindow* window, uint32_t key)
|
||||
}
|
||||
}
|
||||
|
||||
return xkb_keymap_key_repeats(_glfw.wl.xkb.keymap, syms[0]);
|
||||
return xkb_keymap_key_repeats(_glfw.wl.xkb.keymap, code);
|
||||
}
|
||||
|
||||
static void keyboardHandleKey(void* data,
|
||||
|
Loading…
Reference in New Issue
Block a user