From 11f517e557244f52c73a779c13bc2e2417cc67f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Camilla=20L=C3=B6wy?= Date: Fri, 1 Dec 2023 13:22:11 +0100 Subject: [PATCH] Fix return value on error for glfwGetKeyScancode The documentation says it should be -1, not zero. (cherry picked from commit 8c5471d6cdc6d87935e494b8c379f659e998bcf6) --- README.md | 1 + src/input.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 9f91667a..19e361c6 100644 --- a/README.md +++ b/README.md @@ -123,6 +123,7 @@ information on what to include when reporting a bug. ## Changelog + - Bugfix: `glfwGetKeyScancode` returned `0` on error when initialized instead of `-1` - [Win32] Fix pkg-config for dynamic library on Windows (#2386, #2420) - [Win32] Bugfix: `glfwWaitEventsTimeout` did not return for some sent messages (#2408) - [Wayland] Added improved fallback window decorations via libdecor (#1639,#1693) diff --git a/src/input.c b/src/input.c index 7ea1222c..047d75dc 100644 --- a/src/input.c +++ b/src/input.c @@ -636,7 +636,7 @@ GLFWAPI int glfwGetKeyScancode(int key) if (key < GLFW_KEY_SPACE || key > GLFW_KEY_LAST) { _glfwInputError(GLFW_INVALID_ENUM, "Invalid key %i", key); - return GLFW_RELEASE; + return -1; } return _glfwPlatformGetKeyScancode(key);